[pcap-ng-format] [OPSAWG] draft-gharris-opsawg-pcap.txt --- FCS length description

[Michael Richardson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512


Carsten Bormann <cabo at tzi.org> wrote:
    > On 2020-12-22, at 01:31, Michael Richardson <mcr+ietf at sandelman.ca> wrote:
    >>
    >> #define LT_FCS_LENGTH(x)		(((x) & 0xF0000000) >> 28)
    >> #define LT_FCS_DATALINK_EXT(x)		((((x) & 0xF) << 28) | 0x04000000)
    >>
    >> this suggests that the FCS length is really only 3 bits

    > 4 bits, really (assuming 32-bit unsigned integers).

The LT_FCS_LENGTH(x) (bit 28) is treated as a flag to say that the thing is there.
The DATALINK_EXT(x) might be borked here, only accepting odd values, which
would really be a problem.  I suspect there are bugs here.

- --
Michael Richardson <mcr+IETF at sandelman.ca>   . o O ( IPv6 IøT consulting )
           Sandelman Software Works Inc, Ottawa and Worldwide




-----BEGIN PGP SIGNATURE-----

iQEzBAEBCgAdFiEEbsyLEzg/qUTA43uogItw+93Q3WUFAl/hcmwACgkQgItw+93Q
3WWUmQf/cGNrWzIqKeCjf8u76FPPEDckcL9/6EObSfKkiQ+qvdjqcG5FQnBngHmO
Wpj9sodteZaqsWtRvz3KckChk94WGPZ/1QcoCNo31Lpa5sYsDI0NYBPjD8NNsOLg
z4IINSHjhY4jVxVJuvDDf31e1vAnlKze8uFCnPZ954V6p3k1pV6xcAYtOvXWThKt
XKu0MwXX2GkXoHabpmYJesVL1s1LZDKZ4R8reAzbx+DFyDyM/0qYYprrjOUO6xGd
FkaQaJ37D08TTZ9sjrpJ9xKruPysTYc7QluXgtCuAGtvqeU56wAaWVPJxhzNK4N3
mrApAK/q4NBEjyTP0A/BYD4HcRDW4Q==
=pfBZ
-----END PGP SIGNATURE-----